I recommend rejecting this patch, as IMHO the current code is working - although perhaps not doing what dmitrys want.Changing behaviour that could have unexpected side effects is not a good idea, no matter how innocuous it might seem.See - https://chdk.setepontos.com/index.php?topic=13091.msg133556#msg133556
Patch to localize the remaining module names (not included in the previous patch due to false perception of the existence of "system modules").Added strings:"RAW Operations""Shot Histogram""Hex Number Editor""Text Box"Replaced "dll" names with existing menu strings.Included Russian translation.
Quote from: dmitrys on 25 / June / 2017, 20:20:39Patch to fix the partition type being incorrectly reported by get_partitionInfo() as discussed.I fixed the partition size as well. I'll post an updated patch as soon as we settle on backwards compatibility.
Patch to fix the partition type being incorrectly reported by get_partitionInfo() as discussed.
Patch with a backward-compatible implementation attached.
For a dual partition card, this appears to change the 'size' value returned by luaCB_get_partitionInfo from the size of the large partition where photos will be saved, to the size of the small (bootable) partition.Phil.
Quote from: dmitrys on 20 / June / 2017, 19:04:47Patch to localize the remaining module names (not included in the previous patch due to false perception of the existence of "system modules").Added strings:"RAW Operations""Shot Histogram""Hex Number Editor""Text Box"Replaced "dll" names with existing menu strings.Included Russian translation.Attached are two separate patches - one without the russian.lng changes and a separate one with those isolated.As for the File Browser localization patch, I suggest that I submit it along with the revamped File Browser changes.
Quote from: philmoz on 27 / June / 2017, 18:03:19For a dual partition card, this appears to change the 'size' value returned by luaCB_get_partitionInfo from the size of the large partition where photos will be saved, to the size of the small (bootable) partition.Phil.That's partially correct. That value has nothing to do with partition info (it doesn't even return the size of a partition). Anyway, this should "fix" that.
AFAIK, the ModuleName field, for modules with a type of 'MTYPE_EXTENSION', is not used in the core CHDK code.In this case, moving these strings to the language file(s) serves no purpose, and just wastes memory.Phil.
The return value from GetTotalCardSpaceKb is the size of the photos partition in kilobytes - how is that not the size of the partition?
Patch is in unicode (again).
Quote from: philmoz on 27 / June / 2017, 18:30:31AFAIK, the ModuleName field, for modules with a type of 'MTYPE_EXTENSION', is not used in the core CHDK code.In this case, moving these strings to the language file(s) serves no purpose, and just wastes memory.Phil.Purpose.
As for memory use, do these couple of dozens extra bytes really matter?
If I may remind you, the entire main menu is kept in memory for reasons that are still beyond me.
Started by andre117 General Discussion and Assistance
Started by Bernd R General Discussion and Assistance
Started by quid « 1 2 » General Discussion and Assistance
Started by zell « 1 2 » General Discussion and Assistance
Started by srsa_4c « 1 2 » General Discussion and Assistance