Adding new cameras, applying patches into trunk (with source code prepared) - page 164 - General Discussion and Assistance - CHDK Forum supplierdeeply

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1636 Replies
  • 487427 Views
*

Offline srsa_4c

  • ******
  • 4142
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1630 on: 15 / December / 2019, 11:32:40 »
Advertisements
Your fix looks OK to me.
Thanks, committed. Fortunately, it was a rather benign bug - as long as malloc succeeded.

*

Offline blackhole

  • *****
  • 737
  • A590IS 101b
    • Planetary astrophotography
Source code for ixus275_elph350, firmware version 100a.

*

Online reyalp

  • ******
  • 12429
Source code for ixus275_elph350, firmware version 100a.
Thanks, added in trunk r5435
Don't forget what the H stands for.

*

Offline blackhole

  • *****
  • 737
  • A590IS 101b
    • Planetary astrophotography
Source code for sx620hs, firmware version 100b.


*

Online reyalp

  • ******
  • 12429
Source code for sx620hs, firmware version 100b.
Thanks. Added in trunk 5448
Don't forget what the H stands for.

*

Offline srsa_4c

  • ******
  • 4142
Two propset 12 related changes from my m100 patch that are not in trunk yet.
Code: [Select]
Index: core/shooting.c
===================================================================
--- core/shooting.c (revision 5449)
+++ core/shooting.c (working copy)
@@ -135,7 +135,7 @@
 int shooting_get_digital_zoom_mode(void)
 {
     int x=shooting_get_prop(PROPCASE_DIGITAL_ZOOM_MODE);
-#if CAM_PROPSET == 7 || CAM_PROPSET == 9 || CAM_PROPSET == 10|| CAM_PROPSET == 11
+#if CAM_PROPSET == 7 || CAM_PROPSET == 9 || CAM_PROPSET == 10 || CAM_PROPSET == 11 || CAM_PROPSET == 12
     if(x==1) {
         return 0;
     }
Index: platform/generic/wrappers.c
===================================================================
--- platform/generic/wrappers.c (revision 5449)
+++ platform/generic/wrappers.c (working copy)
@@ -95,7 +95,7 @@
 long set_property_case(long id, void *buf, long bufsize)
 {
     // ignore set on fake prop
-#if CAM_PROPSET == 7 || CAM_PROPSET == 9 || CAM_PROPSET == 10 || CAM_PROPSET == 11
+#if CAM_PROPSET == 7 || CAM_PROPSET == 9 || CAM_PROPSET == 10 || CAM_PROPSET == 11 || CAM_PROPSET == 12
     if(id==PROPCASE_SHOOTING) {
         return 0;
     }
The second one is clearly needed, not sure about the first one (no digital zoom here).

*

Online reyalp

  • ******
  • 12429
Two propset 12 related changes from my m100 patch that are not in trunk yet.
The second one is clearly needed, not sure about the first one (no digital zoom here).
Thanks for catching those, checked in. I wondered how I missed the wrappers one, since sx730 is tested OK, but it turns out I only missed the set_ call  :-[
Don't forget what the H stands for.

 

Related Topics