Adding new cameras, applying patches into trunk (with source code prepared)

  • 1473 Replies
  • 170711 Views
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #130 on: 05 / February / 2011, 21:48:08 »
    Advertisements
    Submitted for approval and possible inclusion in the main trunk as a stable Beta version,  the IXUS120 SD940.

    ixus120_sd940_for_trunk_1054.patch - 0.20MB

    Link is to a TortoiseSVN patch file that inserts the SD940 as cleanly as I think is possible into trunk revision 1054.  I have tested this by downloading 1054 clean from the svn repository, applying the patch and successfully compiling the two firmware versions supported.

    Is there anything else I need to do for this to be considered a (Beta) release candidate ?

    Edit :  updated - see below or http://chdk.setepontos.com/index.php?topic=5855.msg60918#msg60918
    « Last Edit: 06 / February / 2011, 16:55:36 by waterwingz »

    *

    Offline Lebeau

    • ***
    • 187
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #131 on: 06 / February / 2011, 02:02:32 »
    Bonjour tout le monde ! Here is lebeau :)

    I generate a patch file from CHDK Shell, based on trunk 1054 (revision), relative to my "working copy".

    I tested it on my A650.

    Here is the resume of my change:

     ----------- brand new dng.c
     = speed optimization
     = addition of the Canon masked area (to evaluate noise without black framing)
     = addition of some other available DNG tags (e.g.: lens info, focal plane resolution, ... usefull in adobe profile)
    // = thumbnail creation based on YCbCr instead of RGB (faster)
     = !!! RGB thumbnail creation from viewport YCbCr, since YCbCr was interpreted as RGB for non-Adobe software
     = create DNG static data at startup and update dynamic data at capture time (faster)
     = save a visual raw file when creating bad pixel bin file (a new star system is born :))
    ++++++++++++++++++++++++++++++++++++++++++++++
    These are change that could be impact post-dng process like DNG4PS2
    +const int cam_BaselineExposure [ ] = { 0, 1 } instead of ={-1,2};
    +const int cam_BaselineSharpness [ ] = { 1, 1 } instead of ={4,3};
    +const int cam_Resolution [ ] = { 300, 1 } instead of ={180,1};

    These macros were added in camera.h file to permit ...
    +#if defined CAM_MASKED_AREA_X1
    +const int cam_MaskedArea [ ] = { CAM_MASKED_AREA_Y1, CAM_MASKED_AREA_X1, CAM_MASKED_AREA_Y2, CAM_MASKED_AREA_X2 };
    +#endif
    +#if defined CAM_ANTI_ALIAS_STRENGTH
    +const int cam_AntiAliasStrength [ ] = { CAM_ANTI_ALIAS_STRENGTH };
    +#endif
    +#if defined CAM_FOCAL_PLANE_RESOLUTION_X
    +const int cam_FocalPlaneResolutionX [ ] = { CAM_FOCAL_PLANE_RESOLUTION_X };
    +const int cam_FocalPlaneResolutionY [ ] = { CAM_FOCAL_PLANE_RESOLUTION_Y };
    +#endif
    +#if defined CAM_COLORMATRIX2
    +const int cam_ColorMatrix2 [ 9 * 2 ] = { CAM_COLORMATRIX2 };
    +#endif
    +#if defined CAM_FORWARDMATRIX
    +const int cam_ForwardMatrix  [ 9 * 2 ] = { CAM_FORWARDMATRIX };
    +#endif
    +#if defined LENS_INFO
    +const int cam_LensInfo [ ] = { LENS_INFO };
    +#endif
    ++++++++++++++++++++++++++++++++++++++++++++++

     ----------- revisit raw.c
     = speed optimization
     = new explicit dng creation sequence (no more intricated)
     = active area bad pixel patching (faster)

     ----------- revisit motion_detector.c
     = speed optimization
     = add "wait-stability" option which, at startup, delay motion detection until 25% of user threshold is reached
     = launch an immediate shoot as soon as a detection cell is encounter, returning the cell index location as return value
     = on immediate shooting, md_get_cell_diff return the diff value of the triggering cell
     = !!! I fix the calculation of RGB, using (Cb-128 and Cr-128), like histogram does correctly !!!

     ----------- revisit histogram.c
     = speed optimization
     = replace half sampling (123) with full sampling (123456)

    I didn't program C since long time ago and don't know how to deliver to things but I pack a rar file in case you would be interested to hadd my change into next release.

    Slow download, so be patient :(
    lebeau_1054_change_2011_02_11.rar - 0.29MB

    If I could do something else ... I would be please to contribute.

    Lebeau

    P.S.1: My DNG use YCrCb as thumbnail !!! but revert to viewport RGB since other soft see it as RGB :(
    P.S.2:Since I had to understanding viewport, I optimize motion detector and then histogram. RAW was modified to move dng things into dng module and raw things to raw module. Sorry but that's why all these changes are altogether :(

    Moderator edit: followup discussion here: http://chdk.setepontos.com/index.php?topic=6110.msg60927#msg60927
    « Last Edit: 14 / February / 2011, 10:44:41 by Lebeau »

  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #132 on: 06 / February / 2011, 15:31:39 »
    Submitted for approval and possible inclusion in the main trunk as a stable Beta version,  the IXUS120 SD940.

    Updated with one Stub address fix : ixus120_sd940_for_trunk_1054.patch - 0.20MB



    *

    Offline reyalp

    • ******
    • 9955
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #133 on: 13 / February / 2011, 18:50:06 »
    Submitted for approval and possible inclusion in the main trunk as a stable Beta version,  the IXUS120 SD940.

    Updated with one Stub address fix : ixus120_sd940_for_trunk_1054.patch - 0.20MB
    Added in changeset 1056. Thanks!
    Don't forget what the H stands for.


    *

    Offline reyalp

    • ******
    • 9955
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #134 on: 13 / February / 2011, 22:54:41 »
    Below, I have posted a link to a complete version 1043 release with the changes for the S95.  Perhaps someone more comfortable with the patching process could merge this into the trunk.  Thanks.

    http://www.zshare.net/download/8529240391496f6b/
    Aside from being a zip of an entire tree with a bunch of irrelevant white space changes and other random oddities, this doesn't even compile. and...
    Quote from: stubs_entry_2.s
    STUB(FF83457C)
    ???

    Anyway, I've added this in changeset 1059 with enough changes to make it compile .

    Haven't added it to the autobuild, if someone wants to verify that what I've checked in is functional, I can add it as a beta.
    Don't forget what the H stands for.

    *

    Offline philmoz

    • *****
    • 2936
      • Photos
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #135 on: 17 / February / 2011, 17:51:15 »
    Minor patch for SX30 and G12 (patched against changeset 1064).
    - fixed 'off by 1' mistake in get_focal_length (main.c) for both cameras.
    - moved the call to 'capt_seq_hook_raw_here' to fix problem with exposures longer than 1 second not saving RAW/DNG file.

    Regards,
    Phil.
    CHDK ports:
      sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
      g12 (1.00c, 1.00e, 1.00f & 1.00g)
      sx130is (1.01d & 1.01f)
      ixus310hs (1.00a & 1.01a)
      sx40hs (1.00d, 1.00g & 1.00i)
      g1x (1.00e, 1.00f & 1.00g)

    *

    Offline reyalp

    • ******
    • 9955
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #136 on: 19 / February / 2011, 17:30:41 »
    Welcome back Phil.

    I've added this in changeset 1065


    Minor patch for SX30 and G12 (patched against changeset 1064).
    - fixed 'off by 1' mistake in get_focal_length (main.c) for both cameras.
    - moved the call to 'capt_seq_hook_raw_here' to fix problem with exposures longer than 1 second not saving RAW/DNG file.
    Don't forget what the H stands for.

  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #137 on: 20 / February / 2011, 11:05:51 »
    Patch file for trunk 1066 to correct vid_get_viewport_live_fb() in lib.c for IXUS120-SD940 firmware versions 1.02c & 1.03c


    EDIT :  implemented RefreshPhysicalScreen() correctly and removed the hacked version.
    « Last Edit: 20 / February / 2011, 13:42:21 by waterwingz »


    *

    Offline reyalp

    • ******
    • 9955
  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #138 on: 20 / February / 2011, 17:57:47 »
    Patch file for trunk 1066 to correct vid_get_viewport_live_fb() in lib.c for IXUS120-SD940 firmware versions 1.02c & 1.03c
    EDIT :  implemented RefreshPhysicalScreen() correctly and removed the hacked version.
    Added, changeset 1067
    Don't forget what the H stands for.

  • Publish
    Re: Adding new cameras, applying patches into trunk (with source code prepared)
    « Reply #139 on: 20 / February / 2011, 18:29:09 »
    Added, changeset 1067
    Thanks - for adding to trunk and for prompting me to fix those things up in the first place.


     

    Related Topics