Adding new cameras, applying patches into trunk (with source code prepared)

  • 1479 Replies
  • 180849 Views
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #630 on: 21 / January / 2012, 12:31:42 »
Advertisements


I think ubasic is not quite backward compatible.  b=get_usb_power would be equivalent to mode 0, but now it's a syntax error unless you explicitly give it a number.
Darn - tested that case for Lua,  missed it when testing uBasic.  Thanks for checking that for me.

Patch #6 for USB remote V2.  Changes are :

1) Modified get_usb_power for uBasic -  now act as if passed parameter = 0 if none is specified.
2) Deleted unnecessary input modules P.Width and P.Count. Values are maintained by usb_remote_key().
3) Changed code in remote_key() to only calculate USB remote information when conf.remote is true. (Can still get USB state though).
4) General clean-up of some hard coded constants using enums.

*

Offline reyalp

  • ******
  • 10069
Don't forget what the H stands for.

*

Offline srsa_4c

  • ******
  • 3171
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #632 on: 22 / January / 2012, 10:57:13 »
A possible solution to the problem with the A495 keyboard. This was merged 2 days ago into CHDK-DE, a tester in the German forum reported a preliminary success (no 100% report yet).
Bug fixed (it was experienced with CHDK-DE): camera crashed on startup when any script was set to autostart.
The four buttons really seem to be inverted. Idle value of physw_status[2] has already been reported here: http://chdk.setepontos.com/index.php?topic=5570.msg56110#msg56110 .

As the A490's kbd.c is identical, this change may also be useful there.

*

Offline philmoz

  • *****
  • 2936
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #633 on: 23 / January / 2012, 03:20:10 »
A possible solution to the problem with the A495 keyboard. This was merged 2 days ago into CHDK-DE, a tester in the German forum reported a preliminary success (no 100% report yet).
Bug fixed (it was experienced with CHDK-DE): camera crashed on startup when any script was set to autostart.
The four buttons really seem to be inverted. Idle value of physw_status[2] has already been reported here: http://chdk.setepontos.com/index.php?topic=5570.msg56110#msg56110 .

As the A490's kbd.c is identical, this change may also be useful there.


Thanks, very elegant solution.

Applied in changeset 1604 for both A495 and A490.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)


Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #634 on: 27 / January / 2012, 13:36:21 »
Hi, I would like to apply this patch to the stable release-1 0 to update my a3300 port.

This is my first time doing this, but I think I did it correctly.

After creating my patch I reverted the release back so I could test the patch and everything went fine.

Thanks

Updated patch file with fixed hook raw address, and active area values, thanks to Phil!!
« Last Edit: 27 / January / 2012, 21:32:51 by mk11174 »

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #635 on: 27 / January / 2012, 21:31:57 »
Patch #7 for USB Remote V2.   Changes are :

1) New & improved Ricoh CA-1 input module provided by vnd.
2) High speed remote status debugging code provided by vnd.  Available but currently disabled in this patch.
3) Modified pulse counting code so that logic modules get an identical but seperate pulse count from that provide to Lua and uBasic scripts. Avoids a potential race condition when scripts poll for pulse counts and logic modules are also using that value.

*

Offline philmoz

  • *****
  • 2936
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #636 on: 27 / January / 2012, 21:47:03 »
Hi, I would like to apply this patch to the stable release-1 0 to update my a3300 port.

This is my first time doing this, but I think I did it correctly.

After creating my patch I reverted the release back so I could test the patch and everything went fine.

Thanks

Updated patch file with fixed hook raw address, and active area values, thanks to Phil!!

Added in changeset 1617 to release-1.0 branch.

(Will do the main trunk soon.)

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)

*

Offline philmoz

  • *****
  • 2936
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #637 on: 27 / January / 2012, 21:51:58 »
Patch #7 for USB Remote V2.   Changes are :

1) New & improved Ricoh CA-1 input module provided by vnd.
2) High speed remote status debugging code provided by vnd.  Available but currently disabled in this patch.
3) Modified pulse counting code so that logic modules get an identical but seperate pulse count from that provide to Lua and uBasic scripts. Avoids a potential race condition when scripts poll for pulse counts and logic modules are also using that value.


Added in changset 1618.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)


*

Offline srsa_4c

  • ******
  • 3171
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #638 on: 29 / January / 2012, 22:51:06 »
A470 update for release 1.0
- extra long exposures implemented (all 3 fw revisions, tested on 1.02c)
- fixed the dark frame subtraction setting, bug mentioned here: http://chdk.setepontos.com/index.php?topic=3368.msg39071#msg39071 for all 3 revisions
- flash params table and params count fixed (I've verified the addresses manually, so all 3 rev. should be ok)
- defined CAM_STARTUP_CRASH_FILE_OPEN_FIX (previously camera crashed when "refresh" was issued in chdkptp GUI)
- also defined CAM_DETECT_SCREEN_ERASE
- strange check removed from kbd.c
- multiple corrections for 1.02c according to stubs_entry.S (can't be sure it would be ok for the other 2)
- debug code removed from capt_seq.c

A question: finsig_dryos reports different addresses for "rename" and "write". Is there a way to test which function is the correct one?


I would like to update the A430 too (I posted a patch here a while ago). If there's anything I should do differently, just tell me.

Thx.

*

Offline reyalp

  • ******
  • 10069
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #639 on: 30 / January / 2012, 00:19:09 »
A470 update for release 1.0
Thanks. Added in stable changeset 1625 and trunk changeset 1626
Quote
- multiple corrections for 1.02c according to stubs_entry.S (can't be sure it would be ok for the other 2)
If the sig finder values are correct on your cam then I'd say that's good enough to apply them to the other subs.
Quote
A question: finsig_dryos reports different addresses for "rename" and "write". Is there a way to test which function is the correct one?
If they work, then they are probably not wrong. The others might also work.

Quote
I would like to update the A430 too (I posted a patch here a while ago). If there's anything I should do differently, just tell me.
If we ignored a patch without comment, it probably just means we got distracted and missed it. Feel free to remind us. If you can update it for the current tree, that would make it easier to apply.

edit:
I added the patch from here http://chdk.setepontos.com/index.php?topic=3785.msg80082#msg80082 to the release branch in changeset 1627

edit:
and trunk changeset 1628. The kbd.c conflict seemed pretty straightforward, but it would be good if you can check. I just used the added a430 to the same ifdefs it used in the stable version of generic/kbd.c and used the a430/kbd.c from the release branch.
« Last Edit: 30 / January / 2012, 01:12:31 by reyalp »
Don't forget what the H stands for.

 

Related Topics