Adding new cameras, applying patches into trunk (with source code prepared) - page 107 - General Discussion and Assistance - CHDK Forum

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1659 Replies
  • 628761 Views
*

Offline rudi

  • ***
  • 126
  • A590IS_101B, SX260HS_100B
Advertisements
Bugfix for imath library, Changeset 2655.
Patch and desciption please see here: http://chdk.setepontos.com/index.php?topic=9131.msg98857#msg98857

*

Offline reyalp

  • ******
  • 13433
Bugfix for imath library, Changeset 2655.
Patch and desciption please see here: http://chdk.setepontos.com/index.php?topic=9131.msg98857#msg98857
Added, trunk changeset 2673
Don't forget what the H stands for.

*

Offline nafraf

  • *****
  • 1308
A4000 patches
- 101a tested by atirage21, added to autobuild as ALPHA
- Fix to zoom bugs: CAM_USE_ALT_SET_ZOOM_POINT and CAM_USE_ALT_PT_MoveOpticalZoomAt defined
- New value for PAUSE_FOR_FILE_COUNTER.

I got tired of complaining about CHDK shortcut keys and did something about it.  This patch adds a menu item to the CHDK settings menu to allow shortcut keys to be enabled/disabled by the user. 

I realize a full user editable shortcut key menu with individual enable/disables and configurable button choices would be nicer.  But this is a good step and only took a few minutes to code and test.
 
For compatibility,  it defaults shortcuts to be enabled - a compromise I regret but will live with for the benefit of not further confusing new users.


Update : cleaned up the help menu string spacing a bit.  Also capitalized the Enable Shortcut Keys menu item.
« Last Edit: 06 / April / 2013, 18:06:50 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16


*

Offline philmoz

  • *****
  • 3332
    • Photos
A4000 patches
- 101a tested by atirage21, added to autobuild as ALPHA
- Fix to zoom bugs: CAM_USE_ALT_SET_ZOOM_POINT and CAM_USE_ALT_PT_MoveOpticalZoomAt defined
- New value for PAUSE_FOR_FILE_COUNTER.

Added in revision 2674 (trunk) and 2675 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline philmoz

  • *****
  • 3332
    • Photos
I got tired of complaining about CHDK shortcut keys and did something about it.  This patch adds a menu item to the CHDK settings menu to allow shortcut keys to be enabled/disabled by the user. 

I realize a full user editable shortcut key menu with individual enable/disables and configurable button choices would be nicer.  But this is a good step and only took a few minutes to code and test.
 
For compatibility,  it defaults shortcuts to be enabled - a compromise I regret but will live with for the benefit of not further confusing new users.


Update : cleaned up the help menu string spacing a bit.  Also capitalized the Enable Shortcut Keys menu item.

A couple of comments:
- This clashes with my new modules branch on the CONF_INFO item (conf.c) and the new strings in english.lng. Can you move these please.
- The changes in gui_draw_alt_helper are hiding too many lines when you disable the shortcuts. LANG_HELP_HIDE_OSD and LANG_HELP_NOT_ALT should still display.
- The change in gui_kbd_shortcuts will also disable the manual focus overrides for camera that don't have built in manual focus.
- The change only disables Shutter Half Press + button shortcuts, the menu item text 'Enable Shortcut Keys' doesn't reflect this.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline lapser

  • *****
  • 1093
A couple of comments:
- The change in gui_kbd_shortcuts will also disable the manual focus overrides for camera that don't have built in manual focus.
- The change only disables Shutter Half Press + button shortcuts, the menu item text 'Enable Shortcut Keys' doesn't reflect this.
Would it work better where I suggested? Things are always more complicated than they seem in CHDK, aren't they?
http://chdk.setepontos.com/index.php?topic=8932.msg98899#msg98899
Thanks Phil.
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos

A couple of comments:
- This clashes with my new modules branch on the CONF_INFO item (conf.c) and the new strings in english.lng. Can you move these please.
Sheesh  - you haven't updated those to the trunk yet.  Modified to leave a hole based on what's currently in the SVN for your branch.

Quote
- The changes in gui_draw_alt_helper are hiding too many lines when you disable the shortcuts. LANG_HELP_HIDE_OSD and LANG_HELP_NOT_ALT should still display.
Okay - changed to leave those in.

Quote
The change in gui_kbd_shortcuts will also disable the manual focus overrides for camera that don't have built in manual focus.
Changed to leave those enabled - I haven't accidentally hit those so far anyway.

Quote
The change only disables Shutter Half Press + button shortcuts, the menu item text 'Enable Shortcut Keys' doesn't reflect this.
Hmmm .. those are the only one I think of as an actual shortcuts.  Text changed.


Would it work better where I suggested?
No.  Your patch is right before the call to where I patched the code.  Doing it that way would make it impossible to leave the manual focus stuff enabled.
« Last Edit: 06 / April / 2013, 20:39:34 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16


*

Offline nafraf

  • *****
  • 1308
Small patch to sx50/sx260:
sx50/sx260: CAM_USE_ALT_SET_ZOOM_POINT and CAM_USE_ALT_PT_MoveOpticalZoomAt defined
sx260: Configurable ALT button enabled. 
Tested by lapser, thanks

*

Offline philmoz

  • *****
  • 3332
    • Photos
A couple of comments:
- This clashes with my new modules branch on the CONF_INFO item (conf.c) and the new strings in english.lng. Can you move these please.
Sheesh  - you haven't updated those to the trunk yet.  Modified to leave a hole based on what's currently in the SVN for your branch.

http://chdk.setepontos.com/index.php?topic=9532.msg98860#msg98860

I was just about to merge my changes when you posted your patch - and I did say please :)

What about the CONF_INFO item for conf.enable_shortcuts (I'm using 294 for conf.module_logging)?
I'd prefer to put conf.enable_shortcuts as 295, otherwise it will make merging my branch harder.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

 

Related Topics