Av bracketing bug - General Discussion and Assistance - CHDK Forum supplierdeeply

Av bracketing bug

  • 0 Replies
  • 1058 Views
*

Offline funnel

  • ****
  • 349
Av bracketing bug
« on: 03 / August / 2011, 15:58:56 »
Advertisements
I found this problem when playing with av bracketing(-), bracketing from f8 to f3.1. The shooting sequence stopped at f3.5 instead of f3.1. The problem in sx220 is that the av_bracketing function substracts 32, but the last value (from f3.5 to f3.1) needs to be substracted by 14 (336-322).

I took a look at the code in shooting_av_bracketing() and fixed the code
Code: [Select]
    if (((!is_odd && (conf.bracket_type == 0)) || (conf.bracket_type == 1)) && ((bracketing.av96 - bracketing.dav96) >= AV96_MIN))
    {
value -= bracketing.dav96;
    }

to:

Code: [Select]
    if ((!is_odd && (conf.bracket_type == 0)) || (conf.bracket_type == 1))
    {
if((bracketing.av96 - bracketing.dav96) >= AV96_MIN)value -= bracketing.dav96;
else value = AV96_MIN;
    }

Now works fine. Do you see any potential problems with my corrections?

 

Related Topics