the collaborative CHDK build - page 14 - CHDK Releases - CHDK Forum

the collaborative CHDK build

  • 249 Replies
  • 177301 Views
*

Offline fudgey

  • *****
  • 1705
  • a570is
Re: the collaborative CHDK build
« Reply #130 on: 20 / August / 2008, 17:37:19 »
Advertisements
the problem is related somehow (blank+transparent characters) to draw_char function which has been altered due cropped mode zebra and does not output any tranparent pixels

Btw Ljl's patch does not implement cropped zebra. It's active over the entire display.

*

Offline dzsemx

  • ****
  • 302
  • [SX40HS][A650][A630]
Re: the collaborative CHDK build
« Reply #131 on: 20 / August / 2008, 22:10:10 »
it was added as cropped zebra:)
https://tools.assembla.com/chdk/changeset/486

Re: the collaborative CHDK build
« Reply #132 on: 21 / August / 2008, 00:23:36 »
Guys, I am seeing many OSD problems with the changeset/486 updates.

The outlined text and transparent box concept is interesting, but
to me, the current bugs are so visible that the changes should be backed out until it is further tested and corrections are made.

Currently, when any OSD text value gets updated/changed it does not erase the previous text.
It overlays it on top of the old text so it quickly becomes unreadable.

The <ALT> prompt at the bottom also sometimes does not go away when exiting ALT mode.
The battery values clobber each other.
The time values will clobber each other.

Yes the tiny patch that checks for KEY_SHOOT_HALF does help but then the problem just shifts to when the
the shutter button is half pressed.
(Set up your clock to display seconds, to see the problem when the shutter button is pressed).

And by inserting in the key pressed check, you defeat what I thought the purpose of the transparent code was
trying to do, so visually, you are right back where you were without this (but with character black outlining).

I'm not feeling the value of this new transparent capability given its issues.

It is possible to do the character outlining *without* the special transparent checks until that code is properly fixed.

To do that change the last line of the multi if/else inside the draw_char() function in gui_draw.c

Code: [Select]
From:
else if(inside_box && cl>>8!=COLOR_TRANSPARENT) draw_pixel(x+ii ,y+i, cl>>8);

To:
else  draw_pixel(x+ii ,y+i, cl>>8);

That way the OSD works just like it did before but you have character outlining.


--- bill




« Last Edit: 21 / August / 2008, 00:28:31 by bperrybap »

*

Offline dzsemx

  • ****
  • 302
  • [SX40HS][A650][A630]
Re: the collaborative CHDK build
« Reply #133 on: 21 / August / 2008, 01:33:09 »
yeah it's really buggy :)
my patch too:(
but it looks so much better the osd wihout background, i requested once that outlined characters would be nice:)
btw, changing that way will cut off many times the last coloumn of outline from the characters
« Last Edit: 21 / August / 2008, 01:40:31 by dzsemx »

*

Offline dzsemx

  • ****
  • 302
  • [SX40HS][A650][A630]
Re: the collaborative CHDK build
« Reply #134 on: 21 / August / 2008, 02:12:33 »
why does "opt:" "ccd:" "batt:" strings have a leading space???

*

Offline fudgey

  • *****
  • 1705
  • a570is
Re: the collaborative CHDK build
« Reply #135 on: 21 / August / 2008, 03:35:30 »
Hmm judging from the forum download counts and the actual behavior+reports here (I can't compare the patches and assembla history atm.) juciphox 486 adds the "wrong" patch that indeed causes several inconvenient things, see http://chdk.setepontos.com/index.php/topic,1849.msg17482.html#msg17482.

I believe I'm using http://chdk.setepontos.com/index.php/topic,1849.msg17451.html#msg17451 <-- this one in my patched trunk build, with the blink mode change in that thread.

*

Offline dzsemx

  • ****
  • 302
  • [SX40HS][A650][A630]
Re: the collaborative CHDK build
« Reply #136 on: 21 / August / 2008, 03:53:28 »
:) wrong patch... great...
but right now only a few people is reporting bugs.. that's sad :(
btw... i need some programming exercises :D i going to forget programming :P
so i added an all mini histogram mode in my personal build:) and fixed that zebra + transparent osd problem, but probably still there are some bugs
« Last Edit: 21 / August / 2008, 05:37:28 by dzsemx »

*

Offline Hacki

  • ****
  • 359
  • EOS 80D
Re: the collaborative CHDK build
« Reply #137 on: 21 / August / 2008, 08:37:49 »
Quote
but right now only a few people is reporting bugs.. that's sad

Maybe because only a few people are experiencing bugs, or perceive something as bug?

On my camera everything OSD related works just fine.

The filebrowser font hast hat black outline, but actually i like it. I was the one picking out that patch from the thread, but i honestly didnt read the thread very carefully - i just picked the latest patch. And after some tinkering around, it worked with my cam.

Re: the collaborative CHDK build
« Reply #138 on: 21 / August / 2008, 14:10:08 »
Quote
but right now only a few people is reporting bugs.. that's sad

Maybe because only a few people are experiencing bugs, or perceive something as bug?

On my camera everything OSD related works just fine.

The filebrowser font hast hat black outline, but actually i like it. I was the one picking out that patch from the thread, but i honestly didnt read the thread very carefully - i just picked the latest patch. And after some tinkering around, it worked with my cam.

Really?
Have you set your OSD background to "transparent", color = 0x0 and turned on the clock with seconds
or set the battery to report voltage?
Is the int_incr multiplier value stuff working for you?

The problem I see is that when OSD characters are drawn, when the background is transparent, it leaves whatever was there
previously. This means that the prior character is not erased but overwritten.
After a few updates, the character will no longer be readable.

In my opinion, while it does look "nice", "cool", or "better",  to have the transparent background
that allows OSD text to be closer to other camera text/icons, the current character draw code doesn't work well enough use.

I think that this could be made to work, but I don't think it will be as simple as what the current code is doing.

Adding in the check for shutter half pressed isn't a solution. It merely disables the transparent background feature
for any OSD text written when the shutter
is not pressed so you lose the "better" looking visual that the transparent background code was trying to enable.
The half pressed shutter patch solution merely makes it "work" better, when the shutter is not pressed.
It makes it work like it used to work before this transparent background capability was added.
The problem shows up again as soon as you press and hold the shutter button half way down.
Often it may not be seen because there can be a lot of stuff going on on the screen and things are being overlapped or
the screen is being repainted in the case of zebra modes, but it is is still there.

Disable, zebra and enable the clock with seconds and you will see the seconds digits overwrite each other
when the shutter is half pressed.
Also, play with the int_incr stuff. (press the zoom lever to set the integer increment values up/down).
This code will not erase the old text so that you will only see the values increment.

Using a transparent OSD background did work prior to this update.
The transparent background would erase the other text/icons if it overlapped it but it didn't
have all the issues with creating unreadable characters and breaking the int_incr feature as well.

Again, I think that this capability is really cool and can be made to work for OSD text,
but I believe that to do it right will not be easy and requires a more general solution than
what was being done in the draw_char() function.


So my feeling is that since this new transparent feature doesn't really fully work,
lets pull it out until it can be made to work properly.



--- bill


*

Offline Hacki

  • ****
  • 359
  • EOS 80D
Re: the collaborative CHDK build
« Reply #139 on: 21 / August / 2008, 15:08:16 »
Quote
Really?

No.

Quote
Have you set your OSD background to "transparent", color = 0x0

No.

Quote
Is the int_incr multiplier value stuff working for you?

No. Seems like i didnt read carefully enough. My bad. sorry.

Quote
So my feeling is that since this new transparent feature doesn't really fully work,
lets pull it out until it can be made to work properly.

Well. I'd say keep it in & try to fix  it. Juciphox isnt called "experimental" just for fun.





 

Related Topics


SimplePortal © 2008-2014, SimplePortal