a few enhancements, bugfixes - done - page 2 - General Discussion and Assistance - CHDK Forum  

Poll

Day Light saving time option, watcha think about it?

Whats DST? (dont need it)
1 (4.8%)
gimme gimme gimme (need it)
5 (23.8%)
Just a hint twice a year is sufficient
4 (19%)
might be useful
10 (47.6%)
can it cure STDs?
1 (4.8%)

Total Members Voted: 20

a few enhancements, bugfixes - done

  • 88 Replies
  • 30184 Views
*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: a few enhancements, bugfixes
« Reply #10 on: 04 / March / 2008, 13:26:54 »
Advertisements
hah, found out why barney is only seeing the empty frame of the sd card icon. actually, this means his sd card itself is empty. meaning: the fuller the sd card, the fuller the icon. i had my card always roughly at 50% filled so i didnt notice that wontolla implemented it this way.
the question now is: did he do this on purpose?
I'd rather have it the other way around - start with a full sd card icon (if card is empty regarding filespace) and have it vanish by turning transparent over time.
maybe wontolla can look into his function again to fix that, as i always get heavily confused and lost in the draw functions (i hate drawing by coords :D)

regarding the raw/video problem:

i implemented a small check in the raw function:
Code: [Select]
if ((conf.save_raw) & ((m&MODE_SHOOTING_MASK)!=MODE_VIDEO_STD))this works on my a620, and by working  i mean i can still shoot raw. i cant test shooting raw in video mode, as my cam doesnt support it. if i change the condition to
Code: [Select]
if ((conf.save_raw) & ((m&MODE_SHOOTING_MASK)==MODE_VIDEO_STD))  i can't shoot raw anymore. conclusion: on s3is MODE_SHOOTING_MASK doesnt return MODE_VIDEO_STD (for example) but
Code: [Select]
  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_SPEED || 
  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_COMPACT ||
          (o&MODE_SHOOTING_MASK) == MODE_VIDEO_MY_COLORS ||
          (o&MODE_SHOOTING_MASK) == MODE_VIDEO_COLOR_ACCENT ||
                  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_TIME_LAPSE  )   )   
on my a620 the mode always is video_std, regardless of the actual mode. is there an extra mode dial on s3is? i guess then the different modes actually come into effect. maybe an s3is owner/coder can confirm this.
« Last Edit: 04 / March / 2008, 13:39:31 by PhyrePhoX »

Re: a few enhancements, bugfixes
« Reply #11 on: 04 / March / 2008, 13:39:11 »
Deleted
« Last Edit: 22 / April / 2008, 13:33:05 by Barney Fife »
[acseven/admin commented out: please refrain from more direct offensive language to any user. FW complaints to me] I felt it imperative to withdraw my TOTAL participation. Nobody has my permission, nor the right, to reinstate MY posts. Make-do with my quoted text in others' replies only. Bye

*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: a few enhancements, bugfixes
« Reply #12 on: 04 / March / 2008, 13:43:10 »
well the color can be set in visual menu (file space icon). color effects all icons (space bar & icon). but like i said, i guess it will be changed to being transparent when empty.

*

Offline wontolla

  • ****
  • 413
  • S3 & G9 & A720
Re: a few enhancements, bugfixes
« Reply #13 on: 05 / March / 2008, 10:02:18 »
Quote
wontolla implemented it this way. the question now is: did he do this on purpose?
Jejeje yes I did. I thought: "Well, if the battery icon looks full when full of energy, the memory icon should look full when full of photos". "Battery icon full? Good!. Memory icon full? Bad! time to swap cards!"
I do remember thinking people could get confused about this but I thought it can be easily changed if needed.
After two weeks I forgot this issue and yesterday when Barney reported the "malfunction" I didn't remember it was suppoused to behave like this! You know, I never have both my camera and internet connection at the same time to tests things.

Quote
maybe wontolla can look into his function again to fix that, as i always get heavily confused and lost in the draw functions
I will.
I know my icon code is ugly; I had to do it like that (line by line). At first I was drawing a simple square and then erase the little corner, but this looked bad because the corner kept blinking when the display refreshed.

Quote
The icon is pretty large though
Yep, I made it big because the corner thingy gets lost in a smaller icon. Remember I was just fooling around with the CHDK code for the first time, I never thought the icon would be used by other people.
IMO Phox's bar is much more useful for people like you and me concerned about "real state". The SD card icon is just fancy. The newbies will like it and as they get more experience they will disable it.
I can always make it smaller or transparent grey either way, just let me know.

BTW Barney, I didn't know you made the Golden Spiral, I use it all the time it rocks!

@PhyrePhox
I don't mean to be fussy but I noticed the horizontal bar can't be pushed all the way to the right corner of the screen (see figure). Is it possible for you to fix that if you got a chance?


Re: a few enhancements, bugfixes
« Reply #14 on: 05 / March / 2008, 11:26:56 »
Deleted
« Last Edit: 22 / April / 2008, 13:33:30 by Barney Fife »
[acseven/admin commented out: please refrain from more direct offensive language to any user. FW complaints to me] I felt it imperative to withdraw my TOTAL participation. Nobody has my permission, nor the right, to reinstate MY posts. Make-do with my quoted text in others' replies only. Bye

*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: a few enhancements, bugfixes
« Reply #15 on: 06 / March / 2008, 08:02:06 »
Quote
Jejeje yes I did. I thought: "Well, if the battery icon looks full when full of energy, the memory icon should look full when full of photos". "Battery icon full? Good!. Memory icon full? Bad! time to swap cards!"
hm, i think its better to go ALWAYS with "hm, XYZ icon full? GOOD!" ;)
i think i'm gonna change that in your function.

Quote
I don't mean to be fussy but I noticed the horizontal bar can't be pushed all the way to the right corner of the screen (see figure). Is it possible for you to fix that if you got a chance?

yes you are right, the rectangle in the OSD positioning menu is at a fixed size, whereas the icons themselves are dynamically sized (depending on setting and - much more important - on screen size (width & height)) so i have to find a way to draw that rectangle in dynamic size as well. plus i have to kind of reset the position of the spacebar, in case for example someone has the small bar in the right bottom corner (like you in your example pic) and sets its size to fullscreen. gonna do that.

can you please test the stuff about the RAW function in video i wrote earlier about?

Quote
re: SD Icon color -- oddly, on my camera I can change the color of the space-bar, but not the SD card. The SD card is just opaque white, looking exactly like Canon's own icons (so it fits in well with those). I almost suggested adding the option of using the less used "warning" color for it, but people would most likely want that as a default bright red. If they changed the color for the SD card using that then they might miss a low-level warning flashing.
will change that too, didnt notice wontolla "hardcoded" it to black and white. will change it will have same color as spacebar, so you can set it to transparent or something.

thanks for sharing your knowlede on drawing with coords, appreciated :)
though it still is difficult to draw by code, as often we dont have fixed sizes, but have to draw by proportions (like screensize for example).

*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: a few enhancements, bugfixes
« Reply #16 on: 06 / March / 2008, 09:01:19 »
Quote
Quote
Jejeje yes I did. I thought: "Well, if the battery icon looks full when full of energy, the memory icon should look full when full of photos". "Battery icon full? Good!. Memory icon full? Bad! time to swap cards!"
hm, i think its better to go ALWAYS with "hm, XYZ icon full? GOOD!" Wink
i think i'm gonna change that in your function.

That's exactly why I always switch off space/batt icons: letters/figures are unambiguous  :D

wim 

*

Offline wontolla

  • ****
  • 413
  • S3 & G9 & A720
Re: a few enhancements, bugfixes
« Reply #17 on: 06 / March / 2008, 09:49:39 »
Good, so my homework is to make a smaller memory icon while Phyrephox will fix the full vs. empty issue and "unhardcode" the colours.

Quote
can you please test the stuff about the RAW function in video i wrote earlier about?
But of course I will! Sorry, I completely forgot about that. We are discussing different things in this thread and I am far from being multitasking. I also missed the part where you say you can't really test it in your A620. I guess I'm the one who should try to fix this.
Funny thing, months ago, when I lost my video I thought: "Well, one of those CHDK guys will have to solve this problem".
I'll see what I can do. If I can't I will open a new thread to address this.

Quote
That's exactly why I always switch off space/batt icons: letters/figures are unambiguous
Me on the other hand, get distracted with numbers. Some brains deal better with figures and some others with drawings. It's good CHDK is so flexible.
I just can' imagine how some people can use the battery voltage figure.


*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: a few enhancements, bugfixes
« Reply #18 on: 06 / March / 2008, 11:24:39 »
ok, replacing the hardcoded colors was easy, just replace
COLOR_WHITE with MAKE_COLOR(cl, cl) throughout your function.

full vs. empty issue i couldnt resolve though, i am lost in your function. but i guess its really simple, maybe you have a clue.

about the raw thing: gonna build a test for you and barney, maybe i got it now.
btw barney, when testing my build, did you have raw enabled as in "always save raw" or "first shot only"? and when in movie mode, did you enable a special mode like sports or something?

edit: oh, and barney: when you tested my build, video got interrupted, okay. but did it save the raw file? please check that, so i at least know that my check is right, but i placed it in the wrong line of code.

edit2:
statement regarding raw,video & s3is by grAndmaster grAnd:
Quote
Due to S*IS have dedicated button which provides the possibility to capture video in any position of dial wheel, that method (based on get_mode() function) is not applicable to that cameras. And I have no idea where is an another flag of "video shooting" process. It is needed to investigate that.
« Last Edit: 06 / March / 2008, 12:02:34 by PhyrePhoX »

*

Offline wontolla

  • ****
  • 413
  • S3 & G9 & A720
Re: a few enhancements, bugfixes
« Reply #19 on: 06 / March / 2008, 12:16:50 »
Quote
full vs. empty issue i couldnt resolve though, i am lost in your function. but i guess its really simple, maybe you have a clue.
Tricky isn't it? My teachers would kill me if they see it, that is not nice coding. But as I said, I had to do it line by line instead of drawing squares.
I will fix it.

Regarding the video issue. Let me try to find a way to detect when camera is recording video without the get_mode() function.


 

Related Topics


SimplePortal 2.3.6 © 2008-2014, SimplePortal