DNG 1.3 bad pixel handling - testers required please. - RAW Shooting and Processing - CHDK Forum supplierdeeply

DNG 1.3 bad pixel handling - testers required please.

  • 34 Replies
  • 11821 Views
*

Offline philmoz

  • *****
  • 3332
    • Photos
DNG 1.3 bad pixel handling - testers required please.
« on: 10 / April / 2012, 23:20:27 »
Advertisements
In revision 1796 in the main SVN trunk ('unstable' development version), I have added a change for DNG handling.

This updates the DNG version in CHDK to 1.3.0.0 and now uses opcodes in the DNG file for bad pixel handling, instead of generating the badpixel.bin file and mapping out the bad pixels in the camera.

I have put this in the SVN trunk so that people can download the autobuild from http://mighty-hoernsche.de/trunk/download_trunk.htm for testing (instead of having to recompile a local version from a branch).

I would ask that people please test this to make sure it works for as many cameras as possible (I've tested the G12, SX30, SX40, IXUS310 and IXUS700).

It also needs to be tested across as many PC and MAC applications as possible to make sure the DNG 1.3 version is widely supported (works ok on ACR 6 and Lightroom 4).

So please download build 1796 (or later) from the above link, capture some DNG images, load them into your favorite editor and check that the bad pixels are being correctly mapped out.

Thanks,
Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline reyalp

  • ******
  • 13387
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #1 on: 11 / April / 2012, 01:39:10 »
Nice :)

Tested D10 and a540

Files from this version seem to open correctly in ufraw, picasa and irfanview, but the badpixels don't appear to be patched. This is based on eyeballing vs. a similar dng shot with the previous trunk..

dng_validate.exe from the 1.3 SDK http://www.adobe.com/support/downloads/detail.jsp?ftpID=4529 gives the same validate errors as for the old files. I'll post those in another thread. It does recognize the opcodes:
Code: [Select]
Parsing OpcodeList1: 4 opcodes

Opcode: FixBadPixelsConstant, minVersion = 1.3.0.0, flags = 1
Constant: 0
Bayer Phase: 2

Opcode: FixBadPixelsConstant, minVersion = 1.3.0.0, flags = 1
Constant: 1
Bayer Phase: 2

Opcode: FixBadPixelsConstant, minVersion = 1.3.0.0, flags = 1
Constant: 2
Bayer Phase: 2

Opcode: FixBadPixelsConstant, minVersion = 1.3.0.0, flags = 1
Constant: 3
Bayer Phase: 2
Not sure values other than zero are needed for most older cams, but I guess it probably doesn't hurt.

A tiff produced with dng_validate -tif appears to have the badpixels patched, so I'd guess the other programs I tried just don't implement the opcodes.
Don't forget what the H stands for.

*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #2 on: 11 / April / 2012, 01:48:41 »
Files from this version seem to open correctly in ufraw, picasa and irfanview, but the badpixels don't appear to be patched. This is based on eyeballing vs. a similar dng shot with the previous trunk..

That's what I was afraid of - if support for DNG 1.3 is not widespread then it's probably not worth changing CHDK.

Quote
dng_validate.exe from the 1.3 SDK http://www.adobe.com/support/downloads/detail.jsp?ftpID=4529 gives the same validate errors as for the old files. I'll post those in another thread. It does recognize the opcodes:

I'll take a look - if the errors aren't too difficult to fix it's worth sorting them out.

Quote
Not sure values other than zero are needed for most older cams, but I guess it probably doesn't hurt.

I did some more analysis of RAW/DNG files from recent cameras and values from 0-3 are occurring; but I didn't find anything above this.
I initially thought the IXUS220 was going up to 16; but when I re-checked it this was because I was doing the 12 bit extraction wrong.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline reyalp

  • ******
  • 13387
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #3 on: 11 / April / 2012, 02:06:42 »
Files from this version seem to open correctly in ufraw, picasa and irfanview, but the badpixels don't appear to be patched. This is based on eyeballing vs. a similar dng shot with the previous trunk..

That's what I was afraid of - if support for DNG 1.3 is not widespread then it's probably not worth changing CHDK.
If it's supported by some common apps like Lightroom, I'd be tempted give people a DNG format option, because it really is a lot more convenient, and the badpixel file can end up taking quite a bit of RAM. Of course that means we can't just rip out all the badpixel code :(

The programs that don't support opcodes still load the file, so people could still use that and fix the badpixels in their workflow.

FWIW, rawtherapee doesn't seem to support opcodes either.
Don't forget what the H stands for.


*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #4 on: 11 / April / 2012, 02:58:51 »
Files from this version seem to open correctly in ufraw, picasa and irfanview, but the badpixels don't appear to be patched. This is based on eyeballing vs. a similar dng shot with the previous trunk..

That's what I was afraid of - if support for DNG 1.3 is not widespread then it's probably not worth changing CHDK.
If it's supported by some common apps like Lightroom, I'd be tempted give people a DNG format option, because it really is a lot more convenient, and the badpixel file can end up taking quite a bit of RAM. Of course that means we can't just rip out all the badpixel code :(

The programs that don't support opcodes still load the file, so people could still use that and fix the badpixels in their workflow.

FWIW, rawtherapee doesn't seem to support opcodes either.

Do you think this will work?

- leave the DNG version as 1.3
- leave the bad pixel opcodes in the DNG file
- add a new menu option to do DNG bad pixel removal in the camera (requires creation of the badpixel.bin file)

The new menu option would default to off, and when trying to turn it on it will tell you to create the badpixel.bin file if it's not present.

The default then is to have DNG 1.3 with bad pixel opcodes, no badpixel.bin is needed or loaded.
For anyone who really needs it they can create the badpixel.bin file and let CHDK do the mapping.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline blackhole

  • *****
  • 841
  • A590IS 101b
    • Planetary astrophotography
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #5 on: 11 / April / 2012, 04:02:37 »
With the A590 shows only partial success in PS Camera Raw 4.6



*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #6 on: 11 / April / 2012, 04:15:55 »
With the A590 shows only partial success in PS Camera Raw 4.6


Thanks for testing.
Can you upload a sample DNG file to a file share and post a link please.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline blackhole

  • *****
  • 841
  • A590IS 101b
    • Planetary astrophotography
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #7 on: 11 / April / 2012, 04:18:43 »
Wait a minute ..


*

Offline blackhole

  • *****
  • 841
  • A590IS 101b
    • Planetary astrophotography
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #8 on: 11 / April / 2012, 04:39:43 »
Sorry you're waiting for I have a problem with the proxy.


http://www21.zippyshare.com/v/52329719/file.html

*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: DNG 1.3 bad pixel handling - testers required please.
« Reply #9 on: 11 / April / 2012, 07:35:27 »
Sorry you're waiting for I have a problem with the proxy.


http://www21.zippyshare.com/v/52329719/file.html


Thanks for the file.

The header shows DNG version 1.1, not the updated 1.3 (and the bad pixel opcodes are missing from the DNG file).

Did you copy the updated modules directory to your SD card as well as diskboot.bin?

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

 

Related Topics