new branch - CHDK : Elf Edition - Developers wanted - page 11 - General Discussion and Assistance - CHDK Forum

new branch - CHDK : Elf Edition - Developers wanted

  • 316 Replies
  • 123268 Views
Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #100 on: 21 / December / 2011, 16:27:20 »
Advertisements
could you also please check how benchmark work in last trunk(1492).
I actually tested back at 1491 - the module inspector and benchmark were white-on-white and the benchmark would hang.  As I had a strange problem with the build not working and then suddenly working at that point (reported here) I did not mention it.

Do you want me to retest with 1492 ? 
Ported :   A1200    SD940   G10    Powershot N    G16

Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #101 on: 21 / December / 2011, 16:35:21 »
Do you want me to retest with 1492 ?
I mean use 1492 _trunk_ not flat branch. I think no difference if you test 1491.
I would like to understand - is something broken by me or in trunk

Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #102 on: 21 / December / 2011, 16:46:30 »
I mean use 1492 _trunk_ not flat branch. I think no difference if you test 1491.
I would like to understand - is something broken by me or in trunk
Got it now.  Benchmark in the regular trunk also goes to a "white screen" and just seems to sit there. If I press Menu then I go back to the menu.   If I press Func/Set at that point it briefly flashes the preview image and goes back to white.

So I guess its been there all along -  I'm assuming white text on a white background.  Probably the module inspector inherits the same limitation ?
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #103 on: 21 / December / 2011, 16:49:46 »
Got it now.  Benchmark in the regular trunk also goes to a "white screen" and just seems to sit there. If I press Menu then I go back to the menu.   If I press Func/Set at that point it briefly flashes the preview image and goes back to white.

So I guess its been there all along -  I'm assuming white text on a white background.  Probably the module inspector inherits the same limitation ?


See the comments on 'SCREEN_COLOR' in gui_draw.h.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)


Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #104 on: 21 / December / 2011, 16:50:32 »
So I guess its been there all along -  I'm assuming white text on a white background.
I suspect wrong SCREEN_COLOR in defines of your palette in gui_draw.h

Quote
  Probably the module inspector inherits the same limitation ?
Yes. I wrote it based on benchmark as simpliest gui example. :) Just define correct SCREEN_COLOR and you even need only recompile CHDK core

UPD: please notify if benchmark will hangup (If I understand correct it did), while benchmark in trunk is stable.
« Last Edit: 21 / December / 2011, 16:53:47 by tsvstar »

Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #105 on: 21 / December / 2011, 17:02:03 »
I suspect wrong SCREEN_COLOR in defines of your palette in gui_draw.h
In gui_draw.h, many of the palettes do not have a SCREEN_COLOR defined - they just use the default which I'm guessing by the comment in gui_draw.h was recently put there by philmoz (and yes - I could look it up in the SVN).

I'll play with values for my two cameras - palette's 2 & 3 - and update if I can make it look better.

Quote
UPD: please notify if benchmark will hangup (If I understand correct it did), while benchmark in trunk is stable.
I'll check - it might be that I pressed FUNC/SET and that started the benchmark. I'm guessing that the running benchmark looks like a camera hang when you can't see any activity on the LCD ?

Update : no surprise here - putting #define SCREEN_COLOR 0x15 in palette 2 clears things up.  Getting negative values for the SD card RAW write speed is interesting though ...
« Last Edit: 21 / December / 2011, 17:23:55 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline reyalp

  • ******
  • 14098
Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #106 on: 25 / December / 2011, 19:16:17 »
whim,
1. Where can I read how to find useful info in romlog? Unfortunatelly I'm not familiar with this. :(
See here: http://chdk.wikia.com/wiki/Debugging#Camera_crash_logs_.28romlog.29

edit: I guess you already solved the crash, for future reference :)
Don't forget what the H stands for.

*

Offline reyalp

  • ******
  • 14098
Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #107 on: 25 / December / 2011, 20:53:42 »
In changeset 1505 I've merged the latest reyalp-flt branch to the trunk. This is now the "unstable" development branch for CHDK 1.1

Note the autobuild is currently on the release_1.0 branch, so there is no autobuild of the trunk. Hacki is  getting one set up.

tsvstar: Since we have an unstable branch now, you can work directly in the trunk if you want. If you do work on the trunk, please make sure whatever is checked in compiles and generally runs. You can also keep working in a branch if you want. Thanks for all you hard work!

There were a lot of conflicts in the merge. It compiles and runs for me, but please have a look and check that everything looks OK. For future reference, if you are working on a branch and want to merge changes from the trunk, please do them in separate commits from your own changes. If you do it that way, merging back into the trunk is much easier, because we can just skip the changes that are already applied.

I have some questions about the current code:
- in core/kbd.c around line 176 and platform/s95/kbd.c there is a strange special case for S95. I disabled these in changeset 1506
- in script.c, around line 595 the whole if(L) in the file browser return looks like it's obsolete now
- related to the previous, I'm not completely sure pushing into a lua state from the filebrowser callback (file_browser_selected) is safe. I think it should be OK, but if multiple tasks end up changing the lua state, bad things can happen.
- in lib/lang/lang.c lang_strhash31 it looks like the second if ( langid<MAX_LANGID ) can never be reached. Not sure what was intended here.
Don't forget what the H stands for.


Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #108 on: 26 / December / 2011, 04:03:39 »
There were a lot of conflicts in the merge. It compiles and runs for me, but please have a look and check that everything looks OK. For future reference, if you are working on a branch and want to merge changes from the trunk, please do them in separate commits from your own changes. If you do it that way, merging back into the trunk is much easier, because we can just skip the changes that are already applied.
Ok. I'll check is that everything merged ok.

Quote
- in core/kbd.c around line 176 and platform/s95/kbd.c there is a strange special case for S95. I disabled these in changeset 1506
S95 have one additional unused button - RING button. It is even included into common button list but commented there. I do some experiments and found that common key processing is not working for this button for unknown reason. I can't found why. So I just add special case to use it.
In my build I use it as shortcut to call module inspector. So I can easily check at any moment is module loaded/unloaded or not, what impact to the memory.

Quote
- in script.c, around line 595 the whole if(L) in the file browser return looks like it's obsolete now
- related to the previous, I'm not completely sure pushing into a lua state from the filebrowser callback (file_browser_selected) is safe. I think it should be OK, but if multiple tasks end up changing the lua state, bad things can happen.
Yes. You are right.
Unfortunatelly right after return from callback filebrowser is unloaded and so we can't use its buffer to get last selected file later.
I leave code in script.c just in case for now. For now never bad things happens yet.

Quote
- in lib/lang/lang.c lang_strhash31 it looks like the second if ( langid<MAX_LANGID ) can never be reached. Not sure what was intended here.
Thanks to catch. It is my bad merge of different versions hash functions. I'll fix it.
« Last Edit: 26 / December / 2011, 05:07:29 by tsvstar »

Re: new branch - CHDK : Elf Edition - Developers wanted
« Reply #109 on: 26 / December / 2011, 05:05:29 »
There were a lot of conflicts in the merge. It compiles and runs for me, but please have a look and check that everything looks OK
Looks like everything is merged correctly.

I have one additional note:
For this case it is ok to replace one function with another and insert new one in the middle of the list in module_export.c, because this branch was used by few experienced developers yet.
But common rule for this list is: never replace function in the list with another one with different functionality (just renaming is allowed), never change order of functions in it, never delete exited function from the list, never insert new function in the middle of export list.
If some function is obsolete and not existed anymore or should be replaced by another one with different functionality - replace old one by 0 in the list and add new to the end of list (before final zero)

Reason of this requirement: to minimize modules size and core code, symbols are exported as indexes. So, module have no idea what real symbols are in the core. If order of the list is broken, then correspondence symbol is changed - old modules will call different symbol than they expect - module will hangup/shutdown/make bad things.
Surely this will not happens if always completely replace all modules with last update, but I prefer to keep binary compatibility of modules if it is possible.
« Last Edit: 26 / December / 2011, 05:26:08 by tsvstar »

 

Related Topics


SimplePortal 2.3.6 © 2008-2014, SimplePortal