Shot Histogram Request - page 32 - CHDK Releases - CHDK Forum supplierdeeply
« previous next »
Pages: 1 ... 27 28 29 30 31 [32] 33 34 35 36 37 ... 47   Go Down

Shot Histogram Request

  • 467 Replies
  • 109572 Views
*

Offline ahull

  • *****
  • 634
Re: Shot Histogram Request
« Reply #310 on: 04 / July / 2013, 10:10:06 »
Advertisements
lapser, did your revised code ever get merged back in to the development branch?

I was going to try a bit of time lapse on a Ixus 115 HS or perhaps my Ixus 60, but wasn't sure if I still needed a bespoke build to use your enhancements.
Logged
*

Offline reyalp

  • ******
  • 13940
Re: Shot Histogram Request
« Reply #311 on: 04 / July / 2013, 16:03:25 »
Quote from: ahull on 04 / July / 2013, 10:10:06
lapser, did your revised code ever get merged back in to the development branch?
No, lapsers code was never merged into the trunk.

There is certainly some good ideas there that would be nice to have. I'm not averse to having it in CHDK in principle, though it would probably be for 1.3 as 1.2 getting very close to release.

A bit of explanation of why I haven't made effort to get this into the trunk:
The last versions that I saw, the code had a lot of different, not very closely related changes. Some of them were related to working around the lua bug, which has since been fixed. I am much more likely to accept patches that are in clearly defined, digestible chunks. Code dumps of "here's a bunch of cool stuff I did" are not something I want to spend my limited CHDK development time on. I also greatly prefer clear interfaces, even if it doesn't give you the absolute maximum performance or efficiency, and prefer to provide building blocks for scripts rather than have entire features hard coded in the core. In the past I've have accepted things I felt were too ugly but didn't have the time to sort out, and I have almost always come to regret it later. If someone wants to take the features lapser developed and work them into patches with the characteristics outlined above, I'd definitely be happy to consider including them.

Isn't this what the development branch is for, can't we just put in whatever is useful no matter how much of a mess it is? In a word: No. It is acceptable to have a mess in the trunk, but only if there is a clear path to making it something that is eventually acceptable for release and someone committed to doing that work.
Logged
Don't forget what the H stands for.
*

Offline lapser

  • *****
  • 1093
Re: Shot Histogram Request
« Reply #312 on: 05 / July / 2013, 18:00:03 »
Quote from: ahull on 04 / July / 2013, 10:10:06
lapser, did your revised code ever get merged back in to the development branch?

I was going to try a bit of time lapse on a Ixus 115 HS or perhaps my Ixus 60, but wasn't sure if I still needed a bespoke build to use your enhancements.
Sorry, I've been doing a lot of travelling, and we've had family visitors, etc. etc. I haven't had a chance to obsess on CHDK for awhile.

It will take a lot of cleanup to get all the changes into the trunk, as reyalp described. I plan to work on that as soon as the rest of my world settles down again. In the meantime, I can compile you a specific build for a camera/firmware revision as before.

I'm way behind on the trunk changes, but the time lapse script and code changes so far are working great. Let me know your camera info and I'll see if I can get something compiled for you.

Here's a few of the time lapses I've done recently:

http://www.youtube.com/watch?v=BK6Aqpn1zoY#ws

http://www.youtube.com/watch?v=UITD9c6c3Rk#ws

http://www.youtube.com/watch?v=zwGXXJSRPxA#ws

http://www.youtube.com/watch?v=DEU8l2mCMBY#ws

http://www.youtube.com/watch?v=nTzLeq-9z1A#ws
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline lapser

  • *****
  • 1093
Re: Shot Histogram Request
« Reply #313 on: 08 / July / 2013, 20:33:44 »
Attached are the two builds for @ahull

I'll attach the Lua script that goes with them in the next message.
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline lapser

  • *****
  • 1093
Re: Shot Histogram Request
« Reply #314 on: 08 / July / 2013, 20:48:27 »
I attached the script that goes with the above builds.

You can try setting the focus to 1 for hyperfocal distance. That's what I use for my cameras, but it may crash older cameras.

I'm way behind on the build number, but at least the Lua bug that interrupted the script randomly was fixed in this build. I haven't had any script stoppages since then.

Here's the time lapse I did last night at the lake. I talk about the flashes as the sun goes down in the YouTube description. I think they're caused by shutter speed inaccuracy at 1/4000 on the G1X. I haven't seen it on other cameras with shutter speed max set at 1/3200.

http://www.youtube.com/watch?v=bPYX9keMisk#ws
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline ahull

  • *****
  • 634
Re: Shot Histogram Request
« Reply #315 on: 09 / July / 2013, 03:32:42 »
 :D Thanks for that lapser, I will give them a try, hopefully tonight.
Logged
*

Offline hwntw

  • ***
  • 159
Re: Shot Histogram Request
« Reply #316 on: 09 / July / 2013, 05:33:28 »
Hello, @lapser, can you extract the shot histogram/meter bits from this and code them in to CHDK so we can use this interesting development of yours apart from time lapses?

Colin
Logged
Ixus 300HS S100


Windows 10
*

Offline lapser

  • *****
  • 1093
Re: Shot Histogram Request
« Reply #317 on: 09 / July / 2013, 11:57:55 »
Quote from: hwntw on 09 / July / 2013, 05:33:28
Hello, @lapser, can you extract the shot histogram/meter bits from this and code them in to CHDK so we can use this interesting development of yours apart from time lapses?
The shot histogram changes aren't finished, and they're integrated with the shot meter changes at the moment.

However, if you just want the increased precision in
  get_histo_range(from, to [,scale])
I may be able to do that, although reyalp has to approve putting it into the trunk.
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline reyalp

  • ******
  • 13940
Re: Shot Histogram Request
« Reply #318 on: 09 / July / 2013, 16:56:47 »
Quote from: lapser on 09 / July / 2013, 11:57:55
I may be able to do that, although reyalp has to approve putting it into the trunk.
Or one of the other developers.

As I've said before, if changes are in small digestible chunks, I am much likely to spend time on them. Even if there is something I don't like in a patch, if I can understand what is supposed to be doing I may be able to turn it into something I do find acceptable.
Logged
Don't forget what the H stands for.
*

Offline hwntw

  • ***
  • 159
Re: Shot Histogram Request
« Reply #319 on: 10 / July / 2013, 04:51:57 »
Hello,
A good way to start is with Lapser's shot meter feature? Then possibly the shot histogram bit?
Colin
Logged
Ixus 300HS S100


Windows 10
Pages: 1 ... 27 28 29 30 31 [32] 33 34 35 36 37 ... 47   Go Up
« previous next »
 

Related Topics