gps_math.c bug fix - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: [1]   Go Down

gps_math.c bug fix

  • 6 Replies
  • 4100 Views
*

Offline lapser

  • *****
  • 1093
gps_math.c bug fix
« on: 29 / November / 2012, 14:42:28 »
Advertisements
I got tired of seeing warnings from the compiler, so I created this diff file that corrects the problem. I used CDHK shell, so this is a good test to see if the files it creates work.

Is there a convention on naming diff files?

Thanks
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: gps_math.c bug fix
« Reply #1 on: 29 / November / 2012, 18:23:57 »
Quote
Is there a convention on naming diff files?

Name of yours looks clear enough - maybe add the revision it is built against ? trunk2329 ?


wim
« Last Edit: 29 / November / 2012, 20:00:01 by whim »
Logged
*

Offline lapser

  • *****
  • 1093
Re: gps_math.c bug fix
« Reply #2 on: 30 / November / 2012, 03:44:48 »
This one was made from trunk2329.

Does the file work properly to patch the source code?
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: gps_math.c bug fix
« Reply #3 on: 30 / November / 2012, 04:17:58 »
Quote from: lapser on 30 / November / 2012, 03:44:48
This one was made from trunk2329.

Does the file work properly to patch the source code?

Patch applies fine.

There's no real standard - although it helps if the revision is included as wim said.
Also useful if you note whether the patch applies to the trunk, release-1.1 branch or both.

Generally patches are posted here - http://chdk.setepontos.com/index.php?topic=650
Eventually someone will get around to reviewing and committing the patch - although sometimes things get missed so a reminder may be needed :)

I'll commit this one shortly so no need to repost.

Phil.



Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline lapser

  • *****
  • 1093
Re: gps_math.c bug fix
« Reply #4 on: 30 / November / 2012, 16:27:27 »
Quote from: philmoz on 30 / November / 2012, 04:17:58
Patch applies fine.

There's no real standard - although it helps if the revision is included as wim said.
Also useful if you note whether the patch applies to the trunk, release-1.1 branch or both.
It looks like the CHDK shell I'm using only downloads 1.2. The changes I'm making to shot_histo belong only in 1.2 for awhile anyway.

But, does anyone know how to get CHDK shell to download the 1.1 source?
« Last Edit: 30 / November / 2012, 16:47:43 by lapser »
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: gps_math.c bug fix
« Reply #5 on: 30 / November / 2012, 18:50:53 »
Quote from: lapser on 30 / November / 2012, 16:27:27
But, does anyone know how to get CHDK shell to download the 1.1 source?

The source code for the version 1.1 is part of the branches (release-1_1). Use the button 'Branches' for the necessary settings. Then the shell downloads the recent Revision of the version 1.1.

With the options below the 'Branches' button you can switch between trunk and branches.

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline lapser

  • *****
  • 1093
Re: gps_math.c bug fix
« Reply #6 on: 30 / November / 2012, 22:08:00 »
Quote from: msl on 30 / November / 2012, 18:50:53
Quote from: lapser on 30 / November / 2012, 16:27:27
But, does anyone know how to get CHDK shell to download the 1.1 source?

The source code for the version 1.1 is part of the branches (release-1_1). Use the button 'Branches' for the necessary settings. Then the shell downloads the recent Revision of the version 1.1.

With the options below the 'Branches' button you can switch between trunk and branches.

msl
Thanks! Great program. I use it to load new CHDK versions without changing the SD card, and to load new Lua scripts onto the card. I just wish I could move the log files from the camera to the computer after the Lua script runs. Any way to do that? (everyone always want more).
Logged
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos
Pages: [1]   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal