IXUS800_SD700 odd code question? - General Discussion and Assistance - CHDK Forum supplierdeeply

IXUS800_SD700 odd code question?

  • 1 Replies
  • 913 Views
*

Offline philmoz

  • *****
  • 3163
    • Photos
IXUS800_SD700 odd code question?
« on: 03 / December / 2012, 03:48:50 »
Advertisements
I've removed/cleaned up almost all the code that was conditionally compiled based on camera version.

One annoying instance remains in the shooting_can_focus routine:
Code: [Select]
#elif defined (CAMERA_ixus800_sd700)
    // TODO whats the reason for this ?!?
    return (shooting_get_zoom()<8) && (m!=MODE_AUTO) && (m!=MODE_SCN_UNDERWATER);
#else

Does anyone have any idea what this does, and if it's really needed?

According to the platform code for the camera it only has 8 zoom points so 'shooting_get_zoom() < 8' will always return true;

Phil.
« Last Edit: 03 / December / 2012, 03:54:32 by philmoz »
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)

*

Offline srsa_4c

  • ******
  • 4262
Re: IXUS800_SD700 odd code question?
« Reply #1 on: 03 / December / 2012, 12:06:06 »
The Ixus800 was the camera of one of the early developers. I haven't found a real explanation for MODE_AUTO and MODE_SCN_UNDERWATER aside from a commit comment (r296).

http://trac.assembla.com/chdk/changeset/285/branches/nirschi-ixus#file1
https://trac.assembla.com/chdk/changeset/295/trunk/platform/generic/shooting.c
https://trac.assembla.com/chdk/changeset/296/trunk/platform/generic/shooting.c

http://chdk.setepontos.com/index.php?topic=396.msg3076#msg3076 (also see the link in the followup post)

 

Related Topics