Bug(?) in Edge Overlay

icmn78

7
PowerShot S3 IS

Re: Bug(?) in Edge Overlay

« Reply #10 on: 25 / March / 2013, 07:32:31 »

Advertisements

Hey, thanks for the modification! I want to try this on my S3 IS but I have no idea what to do with the attached file.

Logged

srsa_4c

4451

Re: Bug(?) in Edge Overlay

« Reply #11 on: 25 / March / 2013, 13:34:37 »

@icmn78

I have attached a development build. If you're currently using stable (1.1) CHDK, you'll notice that the menu and the controls are different. You'll need at least the main CHDK binaries (diskboot.bin / ps.fir) and the modules (you can just copy the whole archive content to the card).

s3is-100a-1.2.0_edgeovermod-full.7z (572.6 kB - downloaded 47 times.)

edgeoverlay_newoption.png (3.93 kB, 360x270 - viewed 90 times.)

Logged

a1ex

671
ML dev

Re: Bug(?) in Edge Overlay

« Reply #12 on: 08 / April / 2013, 14:54:19 »

Here's a fix for the same problem (if I understand it well) for A2200.

http://chdk.setepontos.com/index.php?topic=6254.msg98970#msg98970

I'm not sure whether the buffers were reused or overwritten, most probably their address changed. As I'm reading the buffer address directly from EDMAC (the thing that writes image data to them), I can be sure they are always up-to-date.

Logged

srsa_4c

4451

Re: Bug(?) in Edge Overlay

« Reply #13 on: 08 / April / 2013, 21:01:14 »

Quote from: a1ex on 08 / April / 2013, 14:54:19

Here's a fix for the same problem (if I understand it well) for A2200.

http://chdk.setepontos.com/index.php?topic=6254.msg98970#msg98970

Thanks for the pointer. Surprisingly the same (adapted) code works on the A410 too (the same EDMAC channel is used).
The code is fine for uses where vid_get_viewport_live_fb() is called at least once for every new frame. If it's not called regularly, it may not deliver the expected frame. ~~I don't know whether we use it for something like that.~~ This may happen when using remote live view.

Quote

I'm not sure whether the buffers were reused or overwritten, most probably their address changed. As I'm reading the buffer address directly from EDMAC (the thing that writes image data to them), I can be sure they are always up-to-date.

Unfortunately it won't help with these (earlier) cameras, as their live buffers are overwritten by the raw data, so the current edge overlay implementation is racing with the sensor readout, and usually fails when the shutter speed is "too high".

« Last Edit: 09 / April / 2013, 09:10:51 by srsa_4c »

Logged

icmn78

7
PowerShot S3 IS

Re: Bug(?) in Edge Overlay

« Reply #14 on: 20 / April / 2013, 09:46:22 »

@srsa_4c,
Sorry for the delay, I haven't been playing with the camera lately. But I really appreciate your effort.

I tried the patch you made, and it works really well! There is just a small user-interface glitch; in LIVE mode, the overlay appears correctly on the screen. After shooting, during the preview the overlay is shown all messed up again. So I first thought it didn't work. But it actually saves a proper overlay to memory. What happens? The overlay is saved twice? It's not a functional problem, it just behaves different than expected.

Anyway, great work and thanks for the patch!

Logged

srsa_4c

4451

Re: Bug(?) in Edge Overlay

« Reply #15 on: 20 / April / 2013, 15:00:00 »

Quote from: icmn78 on 20 / April / 2013, 09:46:22

There is just a small user-interface glitch; in LIVE mode, the overlay appears correctly on the screen. After shooting, during the preview the overlay is shown all messed up again. So I first thought it didn't work. But it actually saves a proper overlay to memory. What happens? The overlay is saved twice?

The messed up version uses a different viewport buffer (one that gets overwritten by the photo). It can probably be avoided, but the current (simple) code change doesn't support that.

Note that the "experimental" build that you're using is not compatible with the development (1.2) builds of CHDK (the configuration data is interpreted differently). If you ever upgrade to such a release, erase CCHDK3.CFG from the card.

I plan to make this change official, but that will probably happen later (weeks, months), as it depends on a larger CHDK change that is currently in development.

Logged