Final patch before I commit this to SVN.This version now only saves config files if there is an actual change to values in the file - instead of updating all the files every time. It saves a bit of memory as well since it no longer needs a complete copy of the entire 'conf' structure.There is a chance I may have the logic wrong so please test and make sure config files are being updated correctly.
--- modules/user_menu_edit.c (revision 3017)+++ modules/user_menu_edit.c (working copy)@@ -813,7 +813,7 @@ int _module_unload() {- conf_save_new_settings_if_changed();+ conf_save(); return 0; }
int _module_unload(){ conf_save(); return 0;}
Quote from: philmoz on 09 / August / 2013, 23:08:40Final patch before I commit this to SVN.This version now only saves config files if there is an actual change to values in the file - instead of updating all the files every time. It saves a bit of memory as well since it no longer needs a complete copy of the entire 'conf' structure.There is a chance I may have the logic wrong so please test and make sure config files are being updated correctly.Patch file does not apply cleanly to the latest 1.3.0 svn version - reject files looks like this :Code: [Select]--- modules/user_menu_edit.c (revision 3017)+++ modules/user_menu_edit.c (working copy)@@ -813,7 +813,7 @@ int _module_unload() {- conf_save_new_settings_if_changed();+ conf_save(); return 0; }so I edited user_menu_edit.c to this Code: [Select]int _module_unload(){ conf_save(); return 0;}
That must have been wrong - the user menu editor now "hangs" up with just the menu title line visible - unresponsive to key presses.
Don't know why the patch would fail there - it applies ok for me on a clean copy of trunk.The change you made is correct though.
It could also be a bad (or incompatible) UMENU4.CFG file from a previous patch version - try deleting CCHDK4.CFG, OSD__4.CFG and UMENU4.CFG from the card then restarting. This will then reload the previous CCHDK3.CFG config.
Played around with this a bit. Mostly looks good.One issue I noticed is that the "reset options to default" seems broken, the options get reset but not saved. At first I thought it was reloading my CCHDK3.CFG on reboot, but even after I deleted all my old cfgs it still doesn't work. Changing an item after resetting seems cause whatever file that setting is in to get updated correctly.
Rebuilt tonight with latest svn update. Camera came up in "default" mode - old CCHDKx.CFG settings from yesterday gone.No big deal - just thought I'd report it.
What config files were on the card, what files are there now?If there was no CCHDK4.CFG it should have loaded CCHDK3.CFG and then created CCHDK4.CFG, UMENU4.CFG and OSD__4.CFG.
Quote from: philmoz on 16 / August / 2013, 21:56:57What config files were on the card, what files are there now?If there was no CCHDK4.CFG it should have loaded CCHDK3.CFG and then created CCHDK4.CFG, UMENU4.CFG and OSD__4.CFG.Screen shot - the cursor line is at the bottom - next down click goes back to the top.Camera date is 08/16/2013. No idea what was there before - sorry. It would have been an svn snapshot from earlier this week.
Started by PS « 1 2 » Feature Requests
Started by philmoz General Discussion and Assistance
Started by waterwingz Completed and Working Scripts
Started by hwntw « 1 2 » General Help and Assistance on using CHDK stable releases
Started by reyalp Completed and Working Scripts